Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add Bash / Shell translation #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

illusional
Copy link
Member

@illusional illusional commented May 29, 2020

Currently only works for command tools

Relates to:

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #28 into master will increase coverage by 0.13%.
The diff coverage is 64.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   52.75%   52.88%   +0.13%     
==========================================
  Files          60       62       +2     
  Lines       10496    10617     +121     
==========================================
+ Hits         5537     5615      +78     
- Misses       4959     5002      +43     
Impacted Files Coverage Δ
...anis_core/translationdeps/supportedtranslations.py 81.81% <20.00%> (-12.63%) ⬇️
janis_core/translations/bash.py 63.96% <63.96%> (ø)
janis_core/tests/test_translation_bash.py 100.00% <100.00%> (ø)
janis_core/tool/tool.py 70.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976f1a3...a1ca9dc. Read the comment docs.

@mr-c
Copy link
Contributor

mr-c commented Apr 29, 2021

Cool! We looked into doing this for CWL, but I'm happy to see it happen here instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants