Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC][Backport] JSON-RPC 2.0 when Client requests #2937

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Liquid369
Copy link
Member

PIVX Core is currently working with a mix of 1.0, 1.1 and 2.0 behaviors for the JSON RPC server.

@Duddino was having issues with a rust json rpc library interfacing with our daemon because of the responses not aligning to the JSON-RPC 2.0 standard behaviors. This backport was identified and has been applied to ensure JSON-RPC 2.0 compatibility.

Behavior changes:

  • Return HTTP 200 "OK" unless there is an error or malformed message
  • Return "error" or "result" not both
  • Streamlined behavior for single and batch requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants