Merge #2878: [Lint] lint spelling

27b0e0c [Lint] lint spelling (Fuzzbawls)

Pull request description:

  Spelling errors can be embarrassing when seen by outside parties, even if they have no impact on the program's operation. This utilizes [Codespell](https://github.com/codespell-project/codespell) to find common spelling errors during the CI's lint stage and will throw an error if any such misspellings are found.

  A whitelist text file is provided to ignore known false positives, and the lint script ignores any third party dependencies as well as translation files.

ACKs for top commit: 27b0e0c
  Liquid369:
    ACK 27b0e0c
  panleone:
    tACK 27b0e0c

Tree-SHA512: 66af61467209306fc1515f3823120583c3826f16794e1af9afa0a5933f3056c023859beeb2d648b52d927e29a8464e07c402aff887203b6008563c8a42349470

build-aux/snap/snapcraft.yaml

@@ -284,7 +284,7 @@ parts:
  fi
  echo "-----------------------------------------------"
  echo "+++++++++++++++++++++++++++++++++++++++++++++++"
- echo "INSTALATION OF ${BINPREF}-${SNAPCRAFT_PROJECT_VERSION}-snap has finished" # List installed files and vars when installation is finished
+ echo "INSTALLATION OF ${BINPREF}-${SNAPCRAFT_PROJECT_VERSION}-snap has finished" # List installed files and vars when installation is finished
  echo "+++++++++++++++++++++++++++++++++++++++++++++++"
  if [ $EXTRALOG = 1 ]; then
  find ${SNAPCRAFT_PART_INSTALL} -type f

contrib/devtools/README.md

@@ -144,7 +144,7 @@ Then do:
 Create and verify timestamps of merge commits
 ---------------------------------------------
 To create or verify timestamps on the merge commits, install the OpenTimestamps
-client via `pip3 install opentimestamps-client`. Then, dowload the gpg wrapper
+client via `pip3 install opentimestamps-client`. Then, download the gpg wrapper
 `ots-git-gpg-wrapper.sh` and set it as git's `gpg.program`. See
 [the ots git integration documentation](https://github.com/opentimestamps/opentimestamps-client/blob/master/doc/git-integration.md#usage)
 for further details.

contrib/linearize/example-linearize.cfg

@@ -15,5 +15,5 @@ output_file=/home/example/Downloads/bootstrap.dat
 hashlist=hashlist.txt
 split_year=1
 
-# Maxmimum size in bytes of out-of-order blocks cache in memory
+# Maximum size in bytes of out-of-order blocks cache in memory
 out_of_order_cache_sz = 100000000

doc/gitian-building.md

@@ -101,7 +101,7 @@ The build process results in a number of `.assert` files in your local gitian.si
 Signing Externally
 --------------------
 
-If your gitian host does not have your GPG private key installed, you will need to copy these uncommited changes to your host machine, where you can sign them:
+If your gitian host does not have your GPG private key installed, you will need to copy these uncommitted changes to your host machine, where you can sign them:
 
 ```bash
 gpg --output ${VERSION}-linux/${NAME}/pivx-linux-${VERSION%\.*}-build.assert.sig --detach-sign ${VERSION}-linux/$NAME/pivx-linux-${VERSION%\.*}-build.assert

doc/gitian-building/docker-setup-windows.md

@@ -67,6 +67,6 @@ Below are examples that will need to be adjusted to suit your specific machine,
 Proceed to WSL Installation
 -------------------------------
 
-Thats all you need to do for Docker for Windows installation and configuration.
+That's all you need to do for Docker for Windows installation and configuration.
 
 Proceed to [WSL Installation](./wsl-setup-windows.md) for instructions on Installing and configuring WSL.

doc/gitian-building/gitian-setup-fedora.md

@@ -46,7 +46,7 @@ CentOS still ships with Python 2.7, which is incompatible with the gitian-build.
 
 Like as with Python, CentOS ships with an ancient version of Git (1.8.x), which is also not compatible with the gitian-build.py script. The script will detect the old version, and automatically update the system to a newer version of Git.
 
-If you are currently using the default system Git in other work flows, you may need to learn about whats changed in recent versions of Git.
+If you are currently using the default system Git in other work flows, you may need to learn about what's changed in recent versions of Git.
 
 #### Configuring Git
 

src/bench/perf.cpp

@@ -6,7 +6,7 @@
 
 #if defined(__i386__) || defined(__x86_64__)
 
-/* These architectures support quering the cycle counter
+/* These architectures support querying the cycle counter
  * from user space, no need for any syscall overhead.
  */
 void perf_init(void) { }

src/bip38.cpp

@@ -23,7 +23,7 @@ static bool Base58ToHex(const std::string& base58_str, std::string& hex_str)
  if (!DecodeBase58(base58_str.c_str(), vchKey, key_size) || vchKey.size() != key_size) {
  return false;
  }
- // Hex enconding
+ // Hex encoding
  std::stringstream ss;
  ss << std::hex;
  for (unsigned int i = 0; i < vchKey.size(); i++) {

src/bls/bls_worker.cpp

@@ -409,13 +409,13 @@ struct ContributionVerifier : public std::enable_shared_from_this<ContributionVe
  BLSVerificationVectorPtr vvec;
  CBLSSecretKey skShare;
 
- // starts with 0 and is incremented if either vvec or skShare aggregation finishs. If it reaches 2, we know
+ // starts with 0 and is incremented if either vvec or skShare aggregation finishes. If it reaches 2, we know
  // that aggregation for this batch is fully done. We can then start verification.
  std::unique_ptr<std::atomic<int> > aggDone;
 
  // we can't directly update a vector<bool> in parallel
  // as vector<bool> is not thread safe (uses bitsets internally)
- // so we must use vector<char> temporarely and concatenate/convert
+ // so we must use vector<char> temporarily and concatenate/convert
  // each batch result into a final vector<bool>
  std::vector<char> verifyResults;
  };

src/budget/budgetmanager.cpp

@@ -427,7 +427,7 @@ void CBudgetManager::RemoveByFeeTxId(const uint256& feeTxId)
  if (p) {
  LogPrintf("%s: Removing proposal %s (collateral disconnected, id=%s)\n", __func__, p->GetName(), feeTxId.ToString());
  {
- // Erase seen/orhpan votes
+ // Erase seen/orphan votes
  LOCK(cs_votes);
  for (const auto& vote: p->GetVotes()) {
  const uint256& hash{vote.second.GetHash()};
@@ -453,7 +453,7 @@ void CBudgetManager::RemoveByFeeTxId(const uint256& feeTxId)
  if (b) {
  LogPrintf("%s: Removing finalized budget %s (collateral disconnected, id=%s)\n", __func__, b->GetName(), feeTxId.ToString());
  {
- // Erase seen/orhpan votes
+ // Erase seen/orphan votes
  LOCK(cs_finalizedvotes);
  for (const uint256& hash: b->GetVotesHashes()) {
  mapSeenFinalizedBudgetVotes.erase(hash);

src/budget/finalizedbudget.cpp

@@ -350,7 +350,7 @@ TrxValidationStatus CFinalizedBudget::IsTransactionValid(const CTransaction& txN
  // Search the payment
  const CScript& scriptExpected = vecBudgetPayments[nCurrentBudgetPayment].payee;
  const CAmount& amountExpected = vecBudgetPayments[nCurrentBudgetPayment].nAmount;
- // Budget payment is usually the last output of coinstake txes, iterate backwords
+ // Budget payment is usually the last output of coinstake txes, iterate backwards
  for (auto out = txNew.vout.rbegin(); out != txNew.vout.rend(); ++out) {
  LogPrint(BCLog::MNBUDGET,"%s: nCurrentBudgetPayment=%d, payee=%s == out.scriptPubKey=%s, amount=%ld == out.nValue=%ld\n",
  __func__, nCurrentBudgetPayment, HexStr(scriptExpected), HexStr(out->scriptPubKey), amountExpected, out->nValue);

src/ctpl_stl.h

@@ -184,7 +184,7 @@ namespace ctpl {
  }
 
  // run the user's function that excepts argument int - id of the running thread. returned value is templatized
- // operator returns std::future, where the user can get the result and rethrow the catched exceptins
+ // operator returns std::future, where the user can get the result and rethrow the caught exceptions
  template<typename F>
  auto push(F && f) ->std::future<decltype(f(0))> {
  auto pck = std::make_shared<std::packaged_task<decltype(f(0))(int)>>(std::forward<F>(f));

src/cuckoocache.h

@@ -257,7 +257,7 @@ class cache
  *
  * First, epoch_check decrements and checks the cheap heuristic, and then does
  * a more expensive scan if the cheap heuristic runs out. If the expensive
- * scan suceeds, the epochs are aged and old elements are allow_erased. The
+ * scan succeeds, the epochs are aged and old elements are allow_erased. The
  * cheap heuristic is reset to retrigger after the worst case growth of the
  * current epoch's elements would exceed the epoch_size.
  */
@@ -395,7 +395,7 @@ class cache
  * 1) On first iteration, last_loc == invalid(), find returns last, so
  * last_loc defaults to locs[0].
  * 2) On further iterations, where last_loc == locs[k], last_loc will
- * go to locs[k+1 % 8], i.e., next of the 8 indicies wrapping around
+ * go to locs[k+1 % 8], i.e., next of the 8 indices wrapping around
  * to 0 if needed.
  *
  * This prevents moving the element we just put in.

src/cxxtimer.h

@@ -59,7 +59,7 @@ class Timer {
  * Transfer constructor.
  *
  * @param other
- * The object to be transfered.
+ * The object to be transferred.
  */
  Timer(Timer&& other) = default;
 

src/dbwrapper.cpp

@@ -17,7 +17,7 @@ static void SetMaxOpenFiles(leveldb::Options *options) {
  // do not interfere with select() loops. On 64-bit Unix hosts this value is
  // also OK, because up to that amount LevelDB will use an mmap
  // implementation that does not use extra file descriptors (the fds are
- // closed after being mmaped).
+ // closed after being mapped).
  //
  // Increasing the value beyond the default is dangerous because LevelDB will
  // fall back to a non-mmap implementation when the file count is too large.

src/evo/providertx.cpp

@@ -17,7 +17,7 @@ std::string ProRegPL::MakeSignString() const
  ss << EncodeDestination(keyIDOwner) << "|";
  ss << EncodeDestination(keyIDVoting) << "|";
 
- // ... and also the full hash of the payload as a protection agains malleability and replays
+ // ... and also the full hash of the payload as a protection against malleability and replays
  ss << ::SerializeHash(*this).ToString();
 
  return ss.str();

src/httpserver.cpp

@@ -405,7 +405,7 @@ bool InitHTTPServer()
  LogPrintf("HTTP: creating work queue of depth %d\n", workQueueDepth);
 
  workQueue = new WorkQueue<HTTPClosure>(workQueueDepth);
- // tranfer ownership to eventBase/HTTP via .release()
+ // transfer ownership to eventBase/HTTP via .release()
  eventBase = base_ctr.release();
  eventHTTP = http_ctr.release();
  return true;

src/init.cpp

@@ -1255,7 +1255,7 @@ bool AppInitMain()
 
  if (gArgs.GetBoolArg("-resync", false)) {
  uiInterface.InitMessage(_("Preparing for resync..."));
- // Delete the local blockchain folders to force a resync from scratch to get a consitent blockchain-state
+ // Delete the local blockchain folders to force a resync from scratch to get a consistent blockchain-state
  fs::path blocksDir = GetBlocksDir();
  fs::path chainstateDir = GetDataDir() / "chainstate";
  fs::path sporksDir = GetDataDir() / "sporks";

src/libzerocoin/Coin.h

@@ -57,7 +57,7 @@ class PublicCoin
 
  /**Generates a public coin
  *
- * @param p cryptographic paramters
+ * @param p cryptographic parameters
  * @param coin the value of the commitment.
  * @param denomination The denomination of the coin.
  */

src/libzerocoin/CoinSpend.h

@@ -27,7 +27,7 @@
 
 namespace libzerocoin
 {
-// Lagacy zPIV - Only for serialization
+// Legacy zPIV - Only for serialization
 // Proof that a value inside a commitment C is accumulated in accumulator A
 class AccumulatorProofOfKnowledge {
 public:
@@ -46,7 +46,7 @@ class AccumulatorProofOfKnowledge {
  CBigNum s_xi, s_phi, s_gamma, s_psi;
 };
 
-// Lagacy zPIV - Only for serialization
+// Legacy zPIV - Only for serialization
 // Signature of knowledge attesting that the signer knows the values to
 // open a commitment to a coin with given serial number
 class SerialNumberSignatureOfKnowledge {
@@ -59,7 +59,7 @@ class SerialNumberSignatureOfKnowledge {
  std::vector<CBigNum> sprime;
 };
 
-// Lagacy zPIV - Only for serialization
+// Legacy zPIV - Only for serialization
 // Proof that two commitments open to the same value (BROKEN)
 class CommitmentProofOfKnowledge {
 public:
@@ -70,7 +70,7 @@ class CommitmentProofOfKnowledge {
 };
 
 
-// Lagacy zPIV - Only for serialization
+// Legacy zPIV - Only for serialization
 /** The complete proof needed to spend a zerocoin.
  * Composes together a proof that a coin is accumulated
  * and that it has a given serial number.

src/libzerocoin/Params.h

@@ -91,7 +91,7 @@ class AccumulatorAndProofParams {
 
  /**
  * The initial value for the accumulator
- * A random Quadratic residue mod n thats not 1
+ * A random Quadratic residue mod n that's not 1
  */
  CBigNum accumulatorBase;
 
@@ -102,7 +102,7 @@ class AccumulatorAndProofParams {
  CBigNum minCoinValue;
 
  /**
- * Upper bound on the value for a comitted coin.
+ * Upper bound on the value for a committed coin.
  * Required by the accumulator proof.
  */
  CBigNum maxCoinValue;

src/libzerocoin/documentation/Doxyfile

@@ -926,7 +926,7 @@ HTML_STYLESHEET =
 # user-defined cascading style sheet that is included after the standard
 # style sheets created by doxygen. Using this option one can overrule
 # certain style aspects. This is preferred over using HTML_STYLESHEET
-# since it does not replace the standard style sheet and is therefor more
+# since it does not replace the standard style sheet and is therefore more
 # robust against future updates. Doxygen will copy the style sheet file to
 # the output directory.
 
@@ -1736,7 +1736,7 @@ UML_LOOK = NO
 # the class node. If there are many fields or methods and many nodes the
 # graph may become too big to be useful. The UML_LIMIT_NUM_FIELDS
 # threshold limits the number of items for each type to make the size more
-# managable. Set this to 0 for no limit. Note that the threshold may be
+# manageable. Set this to 0 for no limit. Note that the threshold may be
 # exceeded by 50% before the limit is enforced.
 
 UML_LIMIT_NUM_FIELDS = 10

src/llmq/quorums.h

@@ -20,7 +20,7 @@ class CDKGSessionManager;
 
 /**
  * An object of this class represents a quorum which was mined on-chain (through a quorum commitment)
- * It at least contains informations about the members and the quorum public key which is needed to verify recovered
+ * It at least contains information about the members and the quorum public key which is needed to verify recovered
  * signatures from this quorum.
  *
  * In case the local node is a member of the same quorum and successfully participated in the DKG, the quorum object

src/llmq/quorums_dkgsessionhandler.cpp

@@ -172,7 +172,7 @@ bool CDKGSessionHandler::InitNewQuorum(const CBlockIndex* pindexQuorum)
  auto mns = deterministicMNManager->GetAllQuorumMembers(params.type, pindexQuorum);
 
  if (!curSession->Init(pindexQuorum, mns, activeMasternodeManager->GetProTx())) {
- LogPrintf("CDKGSessionHandler::%s -- quorum initialiation failed for %s\n", __func__, curSession->params.name);
+ LogPrintf("CDKGSessionHandler::%s -- quorum initialization failed for %s\n", __func__, curSession->params.name);
  return false;
  }
 

src/llmq/quorums_signing_shares.cpp

@@ -752,7 +752,7 @@ void CSigSharesManager::CollectSigSharesToRequest(std::map<NodeId, std::map<uint
  }
  inv.inv[k.second] = true;
 
- // dont't request it again from this node
+ // don't request it again from this node
  session.announced.inv[i] = false;
  }
  }
@@ -974,7 +974,7 @@ void CSigSharesManager::Cleanup()
  RemoveSigSharesForSession(signHash);
  }
 
- // Remove sessions which were succesfully recovered
+ // Remove sessions which were successfully recovered
  std::set<uint256> doneSessions;
  for (auto& p : sigShares) {
  if (doneSessions.count(p.second.GetSignHash())) {

src/merkleblock.cpp

@@ -163,7 +163,7 @@ uint256 CPartialMerkleTree::ExtractMatches(std::vector<uint256>& vMatch)
  // traverse the partial tree
  unsigned int nBitsUsed = 0, nHashUsed = 0;
  uint256 hashMerkleRoot = TraverseAndExtract(nHeight, 0, nBitsUsed, nHashUsed, vMatch);
- // verify that no problems occured during the tree traversal
+ // verify that no problems occurred during the tree traversal
  if (fBad)
  return UINT256_ZERO;
  // verify that all bits were consumed (except for the padding caused by serializing it as a byte sequence)

src/net_processing.cpp

@@ -1116,7 +1116,7 @@ void static ProcessGetBlockData(CNode* pfrom, const CInv& inv, CConnman* connman
  connman->PushMessage(pfrom, msgMaker.Make(NetMsgType::MERKLEBLOCK, merkleBlock));
  // CMerkleBlock just contains hashes, so also push any transactions in the block the client did not see
  // This avoids hurting performance by pointlessly requiring a round-trip
- // Note that there is currently no way for a node to request any single transactions we didnt send here -
+ // Note that there is currently no way for a node to request any single transactions we didn't send here -
  // they must either disconnect and retry or request the full block.
  // Thus, the protocol spec specified allows for us to provide duplicate txn here,
  // however we MUST always provide at least what the remote peer needs

src/netbase.cpp

@@ -418,7 +418,7 @@ bool static Socks5(std::string strDest, int port, const ProxyCredentials *auth,
  return error("Error reading proxy authentication response");
  }
  if (pchRetA[0] != 0x01 || pchRetA[1] != 0x00) {
- return error("Proxy authentication unsuccesful");
+ return error("Proxy authentication unsuccessful");
  }
  } else if (pchRet1[1] == SOCKS5Method::NOAUTH) {
  // Perform no authentication

src/policy/fees.h

@@ -78,13 +78,13 @@ class TxConfirmStats
  // Count the total # of txs in each bucket
  // Track the historical moving average of this total over blocks
  std::vector<double> txCtAvg;
- // and calcuate the total for the current block to update the moving average
+ // and calculate the total for the current block to update the moving average
  std::vector<int> curBlockTxCt;
 
  // Count the total # of txs confirmed within Y blocks in each bucket
- // Track the historical moving average of theses totals over blocks
+ // Track the historical moving average of these totals over blocks
  std::vector<std::vector<double> > confAvg; // confAvg[Y][X]
- // and calcuate the totals for the current block to update the moving averages
+ // and calculate the totals for the current block to update the moving averages
  std::vector<std::vector<int> > curBlockConf; // curBlockConf[Y][X]
 
  // Sum the total feerate of all tx's in each bucket

src/qt/CMakeLists.txt

@@ -21,7 +21,7 @@ foreach(comp Widgets Core Gui Network LinguistTools DBus Svg Charts)
  add_definitions(${Qt5${comp}_DEFINITIONS})
  list(APPEND Qt5_LIBRARIES ${Qt5${comp}_LIBRARIES})
  else()
- MESSAGE(WARNING "Cant find Qt5${comp}")
+ MESSAGE(WARNING "Can't find Qt5${comp}")
  endif()
 endforeach(comp)
 

src/qt/addresstablemodel.h

@@ -40,7 +40,7 @@ class AddressTableModel : public QAbstractTableModel
  enum EditStatus {
  OK, /**< Everything ok */
  NO_CHANGES, /**< No changes were made during edit operation */
- INVALID_ADDRESS, /**< Unparseable address */
+ INVALID_ADDRESS, /**< Unparsable address */
  DUPLICATE_ADDRESS, /**< Address already in address book */
  WALLET_UNLOCK_FAILURE, /**< Wallet could not be unlocked to create new receiving address */
  KEY_GENERATION_FAILURE /**< Generating a new public key for a receiving address failed */

src/qt/askpassphrasedialog.cpp

@@ -249,7 +249,7 @@ void AskPassphraseDialog::textChanged()
  switch (mode) {
  case Mode::Encrypt: // New passphrase x2
  acceptable = !ui->passEdit2->text().isEmpty() && !ui->passEdit3->text().isEmpty() && // Passphrases are not empty
- ui->passEdit2->text() == ui->passEdit3->text(); // Passphrases match eachother
+ ui->passEdit2->text() == ui->passEdit3->text(); // Passphrases match each other
  break;
  case Mode::UnlockAnonymize: // Old passphrase x1
  case Mode::Unlock: // Old passphrase x1
@@ -258,7 +258,7 @@ void AskPassphraseDialog::textChanged()
  break;
  case Mode::ChangePass: // Old passphrase x1, new passphrase x2
  acceptable = !ui->passEdit2->text().isEmpty() && !ui->passEdit3->text().isEmpty() && // New passphrases are not empty
- ui->passEdit2->text() == ui->passEdit3->text() && // New passphrases match eachother
+ ui->passEdit2->text() == ui->passEdit3->text() && // New passphrases match each other
  !ui->passEdit1->text().isEmpty(); // Old passphrase is not empty
  break;
  }