Wallofcoin Buying Wizard #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Wall of Coin Buying Wizard
|
First comment: Fuck, 17k changes?. :P Will review it in parts. |
furszy
reviewed
May 22, 2018
app/build.gradle
Outdated
| compile 'com.squareup.okhttp3:logging-interceptor:3.3.1' | ||
| compile 'com.squareup.okhttp:logging-interceptor:2.7.5' | ||
| compile 'com.google.code.findbugs:jsr305:2.0.3' | ||
| compile 'org.dashj:dashj-core:0.14.4.3' |
There was a problem hiding this comment.
Why are you using dashj and not the pivxj that is already in the project? This will cause a lot of redundant dependencies
There was a problem hiding this comment.
We have removed dependency of 'org.dashj:dashj-core:0.14.4.3' now.
furszy
reviewed
May 22, 2018
| @@ -75,6 +77,21 @@ public void onRefresh() { | |||
| } | |||
| } | |||
| ); | |||
|
|
|||
| imgEmptyView.setOnClickListener(new View.OnClickListener() { | |||
There was a problem hiding this comment.
This class is called BaseRecyclerFragment, don't add specific logic here. Move your logic down in the class hierarchy.
There was a problem hiding this comment.
We have removed logic "imgEmptyView.setOnClickListener" from BaseRecyclerFragment now.
1) Move logic "imgEmptyView.setOnClickListener " from BaseRecyclerFragment 2) Remove dependancy of 'org.dashj:dashj-core:0.14.4.3' from gradle.
Removed intermediate files & unused files
|
@furszy the good news is that the bulk of these changes are UI-building elements :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Wall of Coin Buying Wizard [Mainnet]
wallofcoins website