Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undelegation #63

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Fix Undelegation #63

merged 1 commit into from
Nov 27, 2022

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Nov 27, 2022

With #38 merged, we can stop doing the ugly hack of only using the first key for undelegation, plus fixes the issue of MPW thinking some delegations were ours.
The current system will NOT recognize the previous stakes made before #38 was merged, not until DeanSparrow/PIVX-BlockExplorer#13 is merged and the explorers updated

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, this is a really nice and simplified solution, and I've verified it resolved Labs' issue of Governance Payout blocks being considered owned delegations.

@JSKitty JSKitty added Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request Mid Priority (~405 PIV) labels Nov 27, 2022
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK: good fix

@JSKitty JSKitty merged commit f82d86c into PIVX-Labs:master Nov 27, 2022
@JSKitty
Copy link
Member

JSKitty commented Nov 27, 2022

🪙 450 PIV bounty fulfilled and sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants