-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Removing Rows or Columns that Include Edge Ranges #3528
Draft
oleibman
wants to merge
27
commits into
PHPOffice:master
Choose a base branch
from
oleibman:pr1449
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 20, 2023
-
WIP Removing Rows or Columns that Include Edge Ranges
This PR will probably remain in draft status for some time. It needs updates, and I need more time to understand exactly what it is doing. It is a replacement for PR PHPOffice#2096, intended as a fix for issue PHPOffice#1449. That PR has been stuck, with a good deal of acrimony, for over 2 years. In the interim, all the parameters for the functions involved were renamed, the functions were refactored to have fewer parameters with new class properties replacing the missing parameters, special code was added for absolute references, and code was refactored putting some of the methods involved in a new class under a new method name. In addition, the original PR was not Php8-compliant (one of the sticking points regarding implementing it), and there were a great many formatting problems (another sticking point). This has made it very difficult to figure out exactly what was intended in the original PR. This PR (a) addresses some of the issues associated with the original issue (deleting columns/rows at the end of a range passed to a formula *on the same sheet*), and (b) does not cause any existing tests to fail. Many more unit tests are needed (another sticking point); in particular, there are changes involving data validations, comments, defined names, and other elements which are not adequately tested. Aside from those, PhpSpreadsheet does not adjust formulas on a different sheet which involve deleted rows/columns, and it should, as Excel does. Similarly, it appears that Excel doesn't do anything extraordinary when the right/bottom part of the range is deleted, but when the left/top part is deleted, it converts the range to #REF! at least some of the time. This needs more research; if confirmed, it needs to be added to PhpSpreadsheet.
Configuration menu - View commit details
-
Copy full SHA for 99d4955 - Browse repository at this point
Copy the full SHA 99d4955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9296381 - Browse repository at this point
Copy the full SHA 9296381View commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f95eac2 - Browse repository at this point
Copy the full SHA f95eac2View commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8e39aff - Browse repository at this point
Copy the full SHA 8e39affView commit details
Commits on Sep 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8bbf5da - Browse repository at this point
Copy the full SHA 8bbf5daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 491fe13 - Browse repository at this point
Copy the full SHA 491fe13View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0fcbf0a - Browse repository at this point
Copy the full SHA 0fcbf0aView commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8d453d - Browse repository at this point
Copy the full SHA c8d453dView commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c6ce160 - Browse repository at this point
Copy the full SHA c6ce160View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e42afc2 - Browse repository at this point
Copy the full SHA e42afc2View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78f6bb0 - Browse repository at this point
Copy the full SHA 78f6bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6400f0a - Browse repository at this point
Copy the full SHA 6400f0aView commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60f3c83 - Browse repository at this point
Copy the full SHA 60f3c83View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 976ff1e - Browse repository at this point
Copy the full SHA 976ff1eView commit details
Commits on May 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dcaf90e - Browse repository at this point
Copy the full SHA dcaf90eView commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30e44f7 - Browse repository at this point
Copy the full SHA 30e44f7View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 25c9bb1 - Browse repository at this point
Copy the full SHA 25c9bb1View commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd7c317 - Browse repository at this point
Copy the full SHA dd7c317View commit details
Commits on Jun 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a4ff0e - Browse repository at this point
Copy the full SHA 6a4ff0eView commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 02ea557 - Browse repository at this point
Copy the full SHA 02ea557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e904b5 - Browse repository at this point
Copy the full SHA 1e904b5View commit details
Commits on Jul 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b64fe6 - Browse repository at this point
Copy the full SHA 7b64fe6View commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48217b9 - Browse repository at this point
Copy the full SHA 48217b9View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 56540d1 - Browse repository at this point
Copy the full SHA 56540d1View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d794e0 - Browse repository at this point
Copy the full SHA 9d794e0View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1f5c308 - Browse repository at this point
Copy the full SHA 1f5c308View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a921d24 - Browse repository at this point
Copy the full SHA a921d24View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.