Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our usage we need to extend the ControllerInvoker to have responses normalised from a generic Payload into a standard Response.
To make this easier it would be helpful if some private methods were instead protected and the Invoker fetching the default resolver chain were separated out from the creation of the ControllerInvoker.
Fixes #105
You can see our proposed implementation of the ControllerInvoker here. With the proposed patch here, that would be vastly simplified and easier to maintain, something like:
Likewise our custom Bridge implementation would be vastly simplified by breaking apart the
Bridge::createControllerInvoker
method from this, to: