Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMRAI: Algorithm/schedule per quantity component #589

Merged
merged 8 commits into from
Oct 1, 2021
Merged

SAMRAI: Algorithm/schedule per quantity component #589

merged 8 commits into from
Oct 1, 2021

Conversation

PhilipDeegan
Copy link
Member

No description provided.

@PhilipDeegan PhilipDeegan changed the title Algo per qty comp SAMRAI: Algorithm/schedule per quantity component Sep 23, 2021
@PHAREHUB PHAREHUB deleted a comment from lgtm-com bot Sep 24, 2021
@PHAREHUB PHAREHUB deleted a comment from lgtm-com bot Sep 24, 2021
@PhilipDeegan PhilipDeegan force-pushed the algo_per_qty_comp branch 2 times, most recently from b5b8882 to 66829ae Compare September 24, 2021 16:28
@PhilipDeegan PhilipDeegan force-pushed the algo_per_qty_comp branch 3 times, most recently from 1f78283 to 6d43712 Compare September 25, 2021 08:45
@PhilipDeegan
Copy link
Member Author

PhilipDeegan commented Sep 27, 2021 •
edited
Loading

It has been observed that in at least for the case of level ghost refinement that there is a discrepancy which appears to be related to SAMRAI imposing the first geometry registered within a schedule to be used in all cases for generating refinement overlaps.
It was seen that in 2d, for some patch layouts that there was mismatch between patches on pure level ghost regions. This mismatch seemed to be related to the fact that the level ghost area covered two coarser patch domains, with both patches belonging to a different MPI domain.

This PR resolves this mismatch by having a schedule for all quantity components independenlty such that they only ever receive the expected geometry and that there is no grouping of components.

Which can be verified with the following tests:

tests/simulator/refinement/test_2d_2_core.py 
tests/simulator/refinement/test_2d_10_core.py

See for further information LLNL/SAMRAI#170

@PhilipDeegan PhilipDeegan mentioned this pull request Oct 1, 2021
Closed
@PhilipDeegan PhilipDeegan merged commit 6d146aa into PHAREHUB:master Oct 1, 2021
@PhilipDeegan PhilipDeegan deleted the algo_per_qty_comp branch October 1, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasaunai nicolasaunai nicolasaunai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipDeegan @nicolasaunai