shared node value consistency #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipDeegan
force-pushed
the
node_val
branch
13 times, most recently
from
04186db
to
4229590
Compare
|
see LLNL/SAMRAI#170 updates in SAMRAI parts... |
PhilipDeegan
force-pushed
the
node_val
branch
3 times, most recently
from
836ef31
to
9944038
Compare
PhilipDeegan
commented
Jun 25, 2021
|
|
||
| cells = [30] * dim | ||
| cells = [60] * dim |
There was a problem hiding this comment.
track this with SAMRAI issue about patch sizes that are too small (<6)
…llest patchsize to 6 to avoid primal node value overlaps of near but not adjacent patches
PhilipDeegan
added a commit
to PhilipDeegan/PHARE
that referenced
this pull request
Jun 28, 2021
reintroduce rtol after PHAREHUB#576 somethings still not right with time interpolating coarser test
…ecide if to overwrite_interior
PhilipDeegan
added a commit
to PhilipDeegan/PHARE
that referenced
this pull request
Jun 30, 2021
rebaserooni if guard cmake mpi python exec function to not launch without MPI tests 2d field refining for subcycle coarsening tests undo undo fit to largest patch size 2d test_density_is_as_provided_by_user init test uncomment pylinting rm debugging try/except tormed PR comments GH action - force double diags nD density fn concurrent python tests that also support mpirun -n > 1, also less dependencies rtol=0, actually mpirun simulator init/advance tests (d'oh) disable test under MPI (for the moment) reenable test with specific boxes that are not near coarser patch box boundaries as these areas are not refined properly in tests fail fast test refine field include ghost of fine version reintroduce rtol after PHAREHUB#576 somethings still not right with time interpolating coarser test
|
obsoleted by #551 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.