Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block data encoding in modern #1376

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix block data encoding in modern #1376

merged 2 commits into from
Aug 10, 2024

Conversation

Pablete1234
Copy link
Member

Simplifies the MaterialCounter and makes modern use relevant ids for the blockstates from the vanilla blockstate registry, instead of a hacky workaround of using just the material id as a stopgap.

@Pablete1234 Pablete1234 added the needs testing This PR requires further testing label Aug 4, 2024
@Pablete1234 Pablete1234 marked this pull request as ready for review August 10, 2024 00:51
@Pablete1234 Pablete1234 merged commit c6f6027 into dev Aug 10, 2024
2 checks passed
@Pablete1234 Pablete1234 deleted the modern-blockstate-ids branch August 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing This PR requires further testing
Development

Successfully merging this pull request may close these issues.

2 participants