Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic pickup-filter NPE #1374

Closed
wants to merge 1 commit into from
Closed

Fix dynamic pickup-filter NPE #1374

wants to merge 1 commit into from

Conversation

Pablete1234
Copy link
Member

Should fix the following NPE:

[20:54:27 WARN]: java.lang.NullPointerException: Cannot invoke "tc.oc.pgm.variables.Variable.getValue(tc.oc.pgm.filters.Filterable)" because "variable" is null
[20:54:27 WARN]:        at tc.oc.pgm.filters.matcher.match.VariableFilter.getValue(VariableFilter.java:55)
[20:54:27 WARN]:        at tc.oc.pgm.filters.matcher.match.VariableFilter.queryTyped(VariableFilter.java:51)
[20:54:27 WARN]:        at tc.oc.pgm.filters.matcher.match.VariableFilter$Generic.queryTyped(VariableFilter.java:75)
[20:54:27 WARN]:        at tc.oc.pgm.filters.matcher.WeakTypedFilter.query(WeakTypedFilter.java:21)
[20:54:27 WARN]:        at tc.oc.pgm.filters.operator.AllFilter.query(AllFilter.java:18)
[20:54:27 WARN]:        at tc.oc.pgm.filters.operator.AllFilter.query(AllFilter.java:18)
[20:54:27 WARN]:        at tc.oc.pgm.filters.operator.AllFilter.query(AllFilter.java:18)
[20:54:27 WARN]:        at tc.oc.pgm.flag.FlagDefinition.canPickup(FlagDefinition.java:192)
[20:54:27 WARN]:        at tc.oc.pgm.flag.Flag.<init>(Flag.java:123)
[20:54:27 WARN]:        at tc.oc.pgm.flag.FlagMatchModule.<init>(FlagMatchModule.java:42)
[20:54:27 WARN]:        at tc.oc.pgm.flag.FlagModule.createMatchModule(FlagModule.java:52)
[20:54:27 WARN]:        at tc.oc.pgm.flag.FlagModule.createMatchModule(FlagModule.java:25)
[20:54:27 WARN]:        at tc.oc.pgm.match.MatchImpl$ModuleLoader.createModule(MatchImpl.java:807)

Signed-off-by: Pablo Herrera <[email protected]>
@Pablete1234 Pablete1234 added the bug Something isn't working label Aug 2, 2024
@Pablete1234
Copy link
Member Author

This does not actually solve the issue, will see how deep i want to go to fix this at a later time

@Pablete1234 Pablete1234 closed this Aug 2, 2024
@Pablete1234 Pablete1234 deleted the add-flag-filter-dep branch August 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants