Restore Objectives as a translatable gamemode #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
approved these changes
Jul 7, 2023
Electroid
approved these changes
Jul 7, 2023
Tested it in localhost and it seemed to work fine Signed-off-by: zzuf <[email protected]>
KingOfSquares
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gamemode titles were hardcoded in #1091, it got suggested that the generic "Objectives" text that appears when some gamemodes are mixed (like DTC and DTM) could still be kept as translatable, as it's more of a special case and not an actual gamemode.
I didn't think it'd cause any confusion, so I tried doing that by simply undoing a couple of changes from that commit. I tested it on a local server and it seemed to work fine.