add bbox auto zoom center and vertex moves independently #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatV
reviewed
Sep 19, 2024
Comment on lines
+368
to
+385
| area = 0 | ||
| min_x = float("inf") | ||
| max_x = float("-inf") | ||
| min_y = float("inf") | ||
| max_y = float("-inf") | ||
|
|
||
| n = len(points) | ||
| # 计算多边形的面积和质心坐标 | ||
| for i in range(n): | ||
| x1 = points[i].x() | ||
| y1 = points[i].y() | ||
| x2 = points[(i + 1) % n].x() | ||
| y2 = points[(i + 1) % n].y() | ||
| area += x1 * y2 - x2 * y1 | ||
| min_x = min(min_x, x1, x2) | ||
| max_x = max(max_x, x1, x2) | ||
| min_y = min(min_y, y1, y2) | ||
| max_y = max(max_y, y1, y2) |
There was a problem hiding this comment.
这段逻辑太复杂了，如果只是计算外接矩形，下面这段代码是不是也可以
for point in points:
x = point.x()
y = point.y()
min_x = min(min_x, x)
max_x = max(max_x, x)
min_y = min(min_y, y)
max_y = max(max_y, y)There was a problem hiding this comment.
还需要计算面积，外接矩形应该改成你这种写法
| "———————————————————————\n" | ||
| "Notice:For Mac users, use the 'Command' key instead of the 'Ctrl' key" | ||
| ) | ||
|
|
||
| return msg | ||
|
|
||
|
|
||
| def polygon_bounding_box_center_and_area(points): |
There was a problem hiding this comment.
min_x, max_x, min_y, max_y初始值为正无穷和负无穷，如果points为空，这些值将保持不变，导致计算的中心坐标为nan。
建议开头添加检查
if len(points) < 3:
raise ValueError("At least three points are required to form a polygon")| 返回: | ||
| 映射后的数值 | ||
| """ | ||
| return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min |
There was a problem hiding this comment.
当in_max - in_min为零时，程序将抛出ZeroDivisionError。应在函数中添加检查，避免这种情况：
if in_max == in_min:
raise ValueError("in_max and in_min cannot be equal")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本次新增两个功能：
1、新增一个开关，用来自动将第一个bbox自动居中放大，适合一张图只有一个标记框的场景，例如车牌识别
2、新增5个快捷键，用来通过键盘的上下左右单独移动bbox的四个顶点，方便精确移动顶点的场景