Fix custom ops bug for pytorch 1.12 and onwards #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code does not work with any available stable version of pytorch, meaning it breaks with colab out of box. The fix is simple: From: NVlabs@c233a91 Adapt to newer _jit_get_operation API that changed in pytorch/pytorch#76814 for NVlabs#188, NVlabs#193
- Switched from jpeg to png as compression artifacts were becoming part of the projection. - Improved description of projection and pytorch seed variables - added save_n_step argument to allow a predetermined number of progress steps rather than each and every one of them - added/tweaked a few debug/process printouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code does not work with any available stable version of pytorch, meaning it breaks with colab out of box. The fix is simple, you should pull it from the official repo since you are downstream from that, it's their latest commit
From: NVlabs@c233a91
Adapt to newer _jit_get_operation API that changed in pytorch/pytorch#76814
for NVlabs#188, NVlabs#193