Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary No-Interlacing patches #324

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Remove unnecessary No-Interlacing patches #324

merged 1 commit into from
Feb 28, 2024

Conversation

PeterDelta
Copy link
Contributor

As of this version: PCSX2/pcsx2#10821 Patches can no longer be disabled per game. These types of patches that are only limited to eliminating the sceGsSetHalfOffset routine were a good fix in old versions but now they have become obsolete, do not improve anything and do worsen the textures and letters, so to keep the games with the least alteration I remove. following that I have verified are no longer necessary.

In Gran Turismo 3 we see that in automatic and the default interlacing modes of pcsx2 they do not act correctly so a patch would be needed.
Gran Turismo 3 automatic

Old patch that eliminates the routine sceGsSetHalfOffset
Gran Turismo 3 routine interlacing

New patch enables progressive interlacing, keeps the sceGsSetHalfOffset routine unchanged, the image does not shake and the scrolling of the letters looks correct. The difference is minimal but it is there.
Gran Turismo 3 progressive

@Mrlinkwii
Copy link
Contributor

Mrlinkwii commented Feb 21, 2024

patches can be disbled on a per game bases but you need to use teh patch menu

image

works here

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Feb 21, 2024

What? I just removed the option to disable the per game settings, control to enable and disable patches per game is still there.

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Feb 21, 2024

I'm not talking about game settings, that works fine. I am referring specifically to the option for Non-Interlacing patches. I understand the reason why that option is removed, but when the option to activate them globally is enabled, the patches that only eliminate the sceGsSetHalfOffset routine are not good. Making a comparison with and without a pcsx2 patch wins by having the automatic option, I hope I have explained myself well
1

@refractionpcsx2
Copy link
Member

Then the patches should be fixed. But I am aware you either enable them globally or only per game, there's no exception option. We've been discussing that.

The reason I said that was because you linked to my pr removing the option to disable per game settings, which is not the same thing.

@PeterDelta
Copy link
Contributor Author

PeterDelta commented Feb 21, 2024

I expressed myself incorrectly, sorry. As I say, I completely understand why this change was made, you have done a great job with the interlacing of pcsx2 and these types of patches are no longer necessary.

@refractionpcsx2 refractionpcsx2 merged commit e3b354f into PCSX2:main Feb 28, 2024
3 checks passed
@refractionpcsx2
Copy link
Member

Alright, cool thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants