GS/HW: Allow moves between swizzled formats #9866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to fix ATV Offroad Fury 2 in native (don't think this effect ever worked with upscaling) So I wouldn't get too hung up on it for now :P I broke ATV somehow anyway lol. |
|
No longer needed, it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Kenran Butousai copies C32->Z24 after some P8H copies, which currently readbacks, then later reuploads incorrectly swizzled.
Since we don't emulate swizzling in HW, we can keep all of this on the GPU.
Marked as a draft, because it makes readbacks blow out in Time Crisis 3, and breaks Kunochi. Also K-1 World Grand Prix, which uses a Z24->Z24 move to copy the framebuffer... and I don't have the energy to deal with that nonsense today.
Rationale behind Changes
Closes #9838.
(note: still partially broken, but matches SW)
Closes #7553.
Suggested Testing Steps
None yet until I fix the aforementioned issues.