x86emitter: Backup and restore non-volatile SSE registers #12183
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XMM6-XMM15 are non-volatile on Windows
JordanTheToaster
approved these changes
Jan 12, 2025
kamfretoz
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMM6-XMM15 are non-volatile on Windows
Description of Changes
On windows, backup and restore XMM5-XMM15 when using
xScopedStackFrameRationale behind Changes
These registers can be clobbered by recompiled code, while the calling code will expect these registers preserved.
This appears to be the cause behind #11549, at least with Jak X when testing with MTVU disabled.
Suggested Testing Steps
Test to make sure I didn't blow up the core