Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese Title Fix (Not -en) & Speed Hacks #12123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nassau-tk
Copy link
Contributor

Description of Changes

Fix Trial & Demo titles.
Fix 2games speed hack.
I used the difference tool to edit it to make sure there was no waste.
I'm sorry to bother you all, but please check.
*I'm not touch name-en: about Zero (Fatal Fram series) & options code.
*I got base .yaml latest file today morinig.

Rationale behind Changes

I couldn't fix it and thought of giving up.
However, if this is not a problem, the modification of the Japanese title is almost finished, so I tried again.
I look forward to your support.
*I don't have any Linux-machine. So, I worked only Win-PC.

Suggested Testing Steps

@TellowKrinkle
Copy link
Member

This looks pretty good. I made a few changes:

  • I separated the name changes into a different commit from the speed hacks.

In doing so, it appears you've also removed the bilinearUpscale: 1 # Smooths out bloom on lights from SCES-52033. I assume that was an accident? If so, I'll undo it.

@nassau-tk
Copy link
Contributor Author

This looks pretty good. I made a few changes:

Oh...Very good Infor for me.

  • I separated the name changes into a different commit from the speed hacks.

I'll leave it to you.

In doing so, it appears you've also removed the bilinearUpscale: 1 # Smooths out bloom on lights from SCES-52033. I assume that was an accident? If so, I'll undo it.

Sorry, Looks like I didn't check it enough.
Of course, I have no intention of deleting it from the original data.
So, It would be helpful if you could restore it.

@TellowKrinkle
Copy link
Member

Of course, I have no intention of deleting it from the original data.
So, It would be helpful if you could restore it.

I restored it.

@Berylskid
Copy link
Contributor

余計なお世話かもしれませんが、これを機にPCSX2のDiscordサーバーに参加してみませんか?
Githubより気軽に質問とかできますし、少数ですが私みたいに日本語できる人もいますよ。

@nassau-tk
Copy link
Contributor Author

余計なお世話かもしれませんが、これを機にPCSX2のDiscordサーバーに参加してみませんか? Githubより気軽に質問とかできますし、少数ですが私みたいに日本語できる人もいますよ。

ありがとうございます!一応Discordは登録してあるんですよ~!
自分は、この程度のテキストいじるレベルしかできないですけどねw
もしディスコで見かけたらよろしくお願いします!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants