Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Always set EnhancedInstructionSet for AVX2 #12118

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

TheLastRar
Copy link
Contributor

@TheLastRar TheLastRar commented Dec 24, 2024

Description of Changes

Replaces the march arguments for clang-cl with the msbuild EnhancedInstructionSet setting

Rationale behind Changes

Intellisense appears unable to infer AVX2 support from the additional march argument, instead relying on the value of EnableEnhancedInstructionSet

Suggested Testing Steps

Test performance in master and PR clang AVX2 builds

Test that non-AVX2 clang still supports none AVX2 systems (presumably it will)

Replaces the march arguments for clang-cl
@seta-san
Copy link
Contributor

I know that’s a super specific situation, b we ut really, avx2 has been around since 2013. It’s basically 2025. I feel bad for the people who have ancient hardware but it’s really time to go full avx2

@JordanTheToaster
Copy link
Member

Correction I am the dumb of ass and fat fingered a setting at some point that cut the FPS of my master build in half woops.

@rayanHappy
Copy link
Contributor

I know that’s a super specific situation, b we ut really, avx2 has been around since 2013. It’s basically 2025. I feel bad for the people who have ancient hardware but it’s really time to go full avx2

Intel has been releasing CPUs that lack support for avx2 until at least 2021. Also you consider hardware from 2013 ancient !

@F0bes F0bes merged commit 6a0f811 into PCSX2:master Dec 25, 2024
12 checks passed
@Valtekken
Copy link
Contributor

I know that’s a super specific situation, b we ut really, avx2 has been around since 2013. It’s basically 2025. I feel bad for the people who have ancient hardware but it’s really time to go full avx2

Intel has been releasing CPUs that lack support for avx2 until at least 2021. Also you consider hardware from 2013 ancient !

This discussion happened already in the corresponding GitHub issue...how many of those CPUs post a benchmark score over the PCSX2 required minimum?

@TheLastRar TheLastRar deleted the vs-clang-arch branch December 25, 2024 12:11
@TheLastRar
Copy link
Contributor Author

Can any further discussion on requiring AVX2 be done in #11382

@PCSX2 PCSX2 locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants