Qt/Patches: Bring back the global WS/NI toggle, but make it clearer in the UI #12117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc9f7e7.
…sabling them per-game is possible This solves a long-standing issue where globally enabled widescreen/no-interlace patches visually appeared as disabled on the patches list, but they were in fact enabled and could NOT be disabled per-game.
…oggles to Patches This old upgrade path telling users that the setting has been deprecated can now be changed to perform the upgrade seamlessly for the user, because the behaviour of the old per-game setting is identical to the new behaviour of the Patches tab.
|
Tested a few games and this pr works pretty well. |
JordanTheToaster
approved these changes
Dec 26, 2024
|
我完全支持您的建议！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
See #12113 for a more specific breakdown of this issue. This PR reverts #12078 while improving the UX of per-game Widescreen/No-Interlace patch toggles. With this PR, the toggles for those two patches in the Patches tab are tri-state and can be changed per-game, overriding the global toggle. Additional text has been added to the screen to indicate the global state of those toggles, to make troubleshooting easier.
As a bonus, this old warning:
has now been removed, and those old per-game settings are now gracefully migrated to Patches, without needlessly notifying the user.
Rationale behind Changes
These global toggles were good, and removing them was a usability downgrade.
Suggested Testing Steps
Fixes #12113