-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Rename input profile #12111
base: master
Are you sure you want to change the base?
UI: Rename input profile #12111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
A very small thing , can the commit have the prefix of UI: |
seems to working good here on linux , its seems the Mac ci has failed @rtavarez98 |
Mac CI fails with;
So you are missing the To better match existing PCSX2 code, I would suggest you instead opt for using our own FileSystem functions (in |
Description of Changes
Adds feature to change a controller input profile and automatically updates the name in all games using the profile.
Rationale behind Changes
Resolves #6507
Suggested Testing Steps
Rename an existing input profile that's assigned to at least one game and check if it's been updated in a game's settings.