Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Rename input profile #12111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rtavarez98
Copy link

Description of Changes

Adds feature to change a controller input profile and automatically updates the name in all games using the profile.

Rationale behind Changes

Resolves #6507

Suggested Testing Steps

Rename an existing input profile that's assigned to at least one game and check if it's been updated in a game's settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@Mrlinkwii
Copy link
Contributor

A very small thing , can the commit have the prefix of UI:

@rtavarez98 rtavarez98 changed the title Rename input profile UI: Rename input profile Dec 23, 2024
@rtavarez98 rtavarez98 marked this pull request as draft December 23, 2024 03:23
@rtavarez98 rtavarez98 marked this pull request as ready for review December 23, 2024 03:52
@Mrlinkwii
Copy link
Contributor

Mrlinkwii commented Dec 23, 2024

seems to working good here on linux , its seems the Mac ci has failed @rtavarez98

@TheLastRar
Copy link
Contributor

TheLastRar commented Dec 23, 2024

Mac CI fails with;

../../pcsx2-qt/Settings/ControllerSettingsWindow.cpp:204:52: error: no member named 'recursive_directory_iterator' in namespace 'std::filesystem'
        for (const auto& game_settings : std::filesystem::recursive_directory_iterator(game_settings_dir))

So you are missing the <filesystem> include
I don't think we use std:;filesystem anywhere else, and I would like additional testing on windows with unicode paths.

To better match existing PCSX2 code, I would suggest you instead opt for using our own FileSystem functions (in common/FileSystem.h). We have the following function which I think will suit your needs;
FindFiles(const char* path, const char* pattern, u32 flags, FindResultsArray* results)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: (Qt) Input profile renaming
3 participants