R5900: Improve the EE cache performance #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just one benchmark for now but in Ape Escape 2 EE cache is 48% faster with the PR.
|
|
With 128 bit SIMD Ape Escape 2 is now 240% faster than master.
|
F0bes
force-pushed
the
I_HEART_EE_CACHE
branch
from
3fb5be9 to
3c53503
Compare
F0bes
force-pushed
the
I_HEART_EE_CACHE
branch
from
e138d78 to
30ad15a
Compare
Mrlinkwii
approved these changes
Dec 26, 2024
|
Okay, this has changed a bunch from the first iteration. I would love for some people to compare the EE cache performance before and after. The increase in performance seems substantial so I'm confident that this is nothing but more performance for all hardware configurations. |
F0bes
force-pushed
the
I_HEART_EE_CACHE
branch
from
30ad15a to
3ba9a15
Compare
|
some good increases acrros the board , im on about a decade old cpu
|
F0bes
force-pushed
the
I_HEART_EE_CACHE
branch
from
d971e5f to
a7eea87
Compare
|
Tested with kill.switch (without the patch) and a custom elf that tests locking half of the cache and they both work. yolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I had a list of optimizations here beforehand (you can view the edit history), but I've replaced it all with SIMD.
When we check to see if an address is part of a cached TLB entry we can do 4 at a time instead of one.
Rationale behind Changes
I want to get more familiar with VTune profiling. The EE cache is also very slow.
Suggested Testing Steps
Test games that require EE cache with this PR (ensure any patches we have for the game are disabled)
Run the EE cache and compare the speed to master.