Savestates: Warn on savestate load and saves without mcd activity #12101
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When the user tries to save or load a state where there hasn't been any memory card activity for ~1 hour, show an OSD warning mentioning the fact that savestates should not be used in place of memory card saves.
Rationale behind Changes
This will hopefully reduce the number of people who rely on savestates and end up in situations where their game can no longer save to memory card.
Suggested Testing Steps
Go in to a game, save to memory card, wait an hour or so, save a state. It should show an OSD warning.
Load the same state, it should show an OSD warning.
Save to memory card again, save a state immediately. The warning should not show up.
Load the same state, it should not show an OSD warning.