Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Add Many Japanese GameTitle #12084

Closed
wants to merge 1 commit into from

Conversation

nassau-tk
Copy link
Contributor

Description of Changes

Fixed a large number of Japanese game titles.
*Trial & Demo will fix later.

Rationale behind Changes

This is a difficult task for non-Japanese people, so I did it myself.
*I'm JP.

Suggested Testing Steps

Put on the "resources" folder and check booting PCSX2.
If the .yaml file has problem then PCSX2 will not boot(Crash).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@Mrlinkwii
Copy link
Contributor

it looks like the CI for cheking thegame-db failed https://github.com/PCSX2/pcsx2/actions/runs/12328904962/job/34415585188?pr=12084

@nassau-tk
Copy link
Contributor Author

Fm...

What is limit at line?

@F0bes
Copy link
Member

F0bes commented Dec 14, 2024

The issue is you have two name keys

FVGK-0015:
  name: "伯爵と妖精 ~夢と絆に思いを馳せて~ [初回限定版]"
  name-sort: "はくしゃくとようせい ゆめときずなにおもいをはせて [しょかいげんていばん]"
  name: "Hakushaku to Yousei - Yume to Kizuna ni Omoi o Hasete [Limited Edition]"                <--- Same key at the second line!!
  region: "NTSC-J"

I think you were intending to set name-en instead
ie

name-en: "Hakushaku to Yousei - Yume to Kizuna ni Omoi o Hasete [Limited Edition]"

@nassau-tk
Copy link
Contributor Author

OK!
I will check once more again.

@nassau-tk nassau-tk closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants