GS/HW: Use proper alpha min max for palettes when looking up a source, adjust dither on blend mix. #12081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's an old source made from target make sure it isn't a palette, alphas need to be used from the palette then.
Allow dither adjust regardless of alpha. usually it is clamed to 1 anyway so we can expand it if alpha max is higher than 128. Expand dither adjust to work in rev subtract conditions.
lightningterror
changed the title
|
Some improvements comparisons on Vulkan with basic blending: Driv3r: Baldur's Gate Dark Alliance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/TC: Use proper alpha min max for palettes when looking up a source.
If it's an old source made from target make sure it isn't a palette, alphas need to be used from the palette then.
GS/HW: Adjust how we handle dithering on blend mix.
Allow dither adjust regardless of alpha. usually it is clamed to 1 anyway so we can expand it if alpha max is higher than 128.
Expand dither adjust to work in rev subtract conditions.
Rationale behind Changes
Accuracy.
Suggested Testing Steps
Test variety of games, dumb runner didn't show anything broken on dx11 and vk, some comparisons are below.