CI: Fix Translation Workflow Scripts Order of Operation #11953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
With how the previous scripts are executed out of order, any strings changes that happens inside BPM will not be picked up by the Qt translation script update on the first run. This PR changes the order of operations for the workflow scripts so that the other scripts for BPM and Glyph ranges are executed first ensuring that the string changes are properly getting picked up by the Qt script as it will be the very last one to be executed.
Rationale behind Changes
Fixing the workflow so that all the translations changes are correctly picked up
Suggested Testing Steps
Nothing for now.