Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE: vtlb handler for writes to IOP mem #11933

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

Ziemas
Copy link
Contributor

@Ziemas Ziemas commented Oct 21, 2024

Description of Changes

Puts EE writes to IOP mem through a handler that calls the write function for IOP mem. This ensures we clear IOP code blocks when EE writes to it.

Rationale behind Changes

The b000p demo (see #3983) has a LoadModuleBuffer patch that is applied with memcpy from the EE. Previously we didn't properly invalidate the cache when this was applied.

Suggested Testing Steps

Check that b000p works and nothing broke 🤷

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@F0bes
Copy link
Member

F0bes commented Oct 21, 2024

Actually I take it back :^)
You have warnings on Windows Clang and Linux.

@Ziemas
Copy link
Contributor Author

Ziemas commented Oct 21, 2024

Fixed

@F0bes F0bes merged commit 67c5f02 into PCSX2:master Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants