DEV9: Set/Clear SEEK bit in all relevent commands #11931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set SEEK when write queue isn't empty
SternXD
pushed a commit
to EmulationCollective/XBSX2
that referenced
this pull request
Dec 7, 2024
* DEV9: Set SEEK on all successful seeks * DEV9: Complete HDD_Flush immediately when write queue is empty Also set SEEK when write queue isn't empty * DEV9: Lock reported value of SEEK when errored
RedPanda4552
pushed a commit
to RedPanda4552/pcsx2
that referenced
this pull request
Dec 20, 2024
* DEV9: Set SEEK on all successful seeks * DEV9: Complete HDD_Flush immediately when write queue is empty Also set SEEK when write queue isn't empty * DEV9: Lock reported value of SEEK when errored
SternXD
pushed a commit
to EmulationCollective/XBSX2
that referenced
this pull request
Dec 22, 2024
* DEV9: Set SEEK on all successful seeks * DEV9: Complete HDD_Flush immediately when write queue is empty Also set SEEK when write queue isn't empty * DEV9: Lock reported value of SEEK when errored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Set/Clear the seek bit any any command could need to seek to complete
Implement holding the value of the SEEK bit when en error occurs
Rationale behind Changes
PS2Linux actually checks for the SEEK bit to determine if a DMA command completed.
The SEEK bit will be set/cleared based on what happens with the command
With the exception of the Flush command, I've opted not to factor in the actions of the write cache.
The holding/locking of the reported value of the SEEK bit as added here is specified in older version of the ATA spec.
The last of my PSBBN prs, Fixes #11924
Suggested Testing Steps
Test HDD software/games