Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD: Update OSD Text on SW mode so no overlap keyword appears #11881

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

knight-ryu12
Copy link
Contributor

Description of Changes

OSD Performance Text in SW mode has overlapped keywords which confuses if D means Drawcall or Download.
This commit fixes it by renaming few stuff and naming it correctly.

Rationale behind Changes

D vs D is off

Suggested Testing Steps

Make sure OSD is OK in SW.

@github-actions github-actions bot added the GS label Oct 7, 2024
Copy link
Member

@JordanTheToaster JordanTheToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is love? Baby don't hurt me, don't hurt me no more.

image

@knight-ryu12
Copy link
Contributor Author

As per request, I applied one more patches to autoscale PPS
It should use G/M/K when it's appropriate
Hardcoding values ahoy

Copy link
Member

@JordanTheToaster JordanTheToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baby is really hurting my CPU usage right now.

image

Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal.

image

@knight-ryu12
Copy link
Contributor Author

hardcoded threshold is
more than 170Mpps for switch over to Gpps
more than 30Mpps for switch over to Mpps
otherwise Kpps.

pcsx2/GS/GS.cpp Outdated Show resolved Hide resolved
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@F0bes F0bes merged commit 8d6633f into PCSX2:master Oct 9, 2024
12 checks passed
@knight-ryu12
Copy link
Contributor Author

Holy

SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Oct 16, 2024
RedPanda4552 pushed a commit to RedPanda4552/pcsx2 that referenced this pull request Dec 20, 2024
SternXD pushed a commit to EmulationCollective/XBSX2 that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants