-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native pixel ratio 640:448 (10:7) #11835
Conversation
Are you able to squash the commits down into one and prefix it? |
Sorry, I'm not very experienced in this. |
I took care of it. You would interactive rebase and mark all of the commits after the first one as squash. Once you finished you would force push back to your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, haven't tested it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested some games with pnach code that includes gsaspectratio=10:7
, and all of them worked flawlessly.
Are you adding these to GameDB? Midnight Club - Street Racing (atleast the NTSC release) has the same "quirk". |
I just checked the game and you are right. It is obvious in the joy settings screen. I usually think that only designers from Japanese companies, especially when porting games from traditional arcades, would keep the 10:7 native ratio.It's hard to imagine a company like Rockstar doing this. |
I think many Japanese game developers were confused as to what aspect ratio should be used. For example: FF X draws squares and ovals with 4:3 or rectangles and circles with the new 10:7 option. Clearly, not everyone agreed on the same aspect ratio when developing this game. Anyways, the new 10:7 aspect ratio seems to work fine for me so far. Thanks for adding it. |
Description of Changes
Add native pixel ratio 640:448 (10:7) for some games.
Rationale behind Changes
Most games have an internal native pixel ratio of 640:448 (10:7), which is then stretched to 4:3, and the developers at the time were also well aware of this. So 4:3 usually gets the correct ratio. However, there are always exceptions, and some game developers seem to insist on using the original pixel ratio instead of 4:3 to express the true effect of the game. If still stretch it to 4:3 in pcsx2, causing the y-axis to be stretched by 7.14% and the character to look a bit thin and long visually.
For example:
Tekken Tag Tournament
4:3 ratio
native ratio
Sengoku Basara X
4:3 ratio
native ratio
Tenchu: Fatal Shadows
Although its internal resolution is 512:448, it seems to follow the 10:7 ratio.
4:3 ratio
10:7 ratio
Suggested Testing Steps
test these games ,maybe there are another more