Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native pixel ratio 640:448 (10:7) #11835

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add native pixel ratio 640:448 (10:7) #11835

merged 1 commit into from
Sep 25, 2024

Conversation

crashGG
Copy link
Contributor

@crashGG crashGG commented Sep 20, 2024

Description of Changes

Add native pixel ratio 640:448 (10:7) for some games.

Rationale behind Changes

Most games have an internal native pixel ratio of 640:448 (10:7), which is then stretched to 4:3, and the developers at the time were also well aware of this. So 4:3 usually gets the correct ratio. However, there are always exceptions, and some game developers seem to insist on using the original pixel ratio instead of 4:3 to express the true effect of the game. If still stretch it to 4:3 in pcsx2, causing the y-axis to be stretched by 7.14% and the character to look a bit thin and long visually.

For example:

Tekken Tag Tournament

4:3 ratio
Tekken Tag Tournament_SLPS-20015_20240920095538
native ratio
Tekken Tag Tournament_SLPS-20015_20240920095519

Sengoku Basara X

4:3 ratio
Sengoku Basara X_SLPM-55008_20240920100742
native ratio
Sengoku Basara X_SLPM-55008_20240920100748

Tenchu: Fatal Shadows
Although its internal resolution is 512:448, it seems to follow the 10:7 ratio.

4:3 ratio
Tenchu Kurenai_SCAJ-20100_20240920103907
10:7 ratio
Tenchu Kurenai_SCAJ-20100_20240920103848

Suggested Testing Steps

test these games ,maybe there are another more

@crashGG
Copy link
Contributor Author

crashGG commented Sep 20, 2024

Mobile Suit Z Gundam - AEUG vs. Titans_SLPS-25305

4:3 ratio
Mobile Suit Z Gundam - AEUG vs  Titans_SLPS-25305_4b3
native ratio
Mobile Suit Z Gundam - AEUG vs  Titans_SLPS-25305_20240920222612

Pay attention to the circles

pcsx2/Pcsx2Config.cpp Outdated Show resolved Hide resolved
pcsx2/Pcsx2Config.cpp Outdated Show resolved Hide resolved
pcsx2-qt/Settings/GraphicsSettingsWidget.ui Show resolved Hide resolved
pcsx2-qt/Settings/GraphicsSettingsWidget.ui Show resolved Hide resolved
pcsx2/GS/Renderers/Common/GSRenderer.cpp Show resolved Hide resolved
pcsx2/Config.h Outdated Show resolved Hide resolved
@F0bes
Copy link
Member

F0bes commented Sep 21, 2024

Are you able to squash the commits down into one and prefix it?

@crashGG
Copy link
Contributor Author

crashGG commented Sep 21, 2024

Are you able to squash the commits down into one and prefix it?

Sorry, I'm not very experienced in this.
Do I need to delete these commits and pr it again?

@F0bes
Copy link
Member

F0bes commented Sep 21, 2024

I took care of it.

You would interactive rebase and mark all of the commits after the first one as squash. Once you finished you would force push back to your branch.

@crashGG crashGG requested a review from F0bes September 21, 2024 18:49
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, haven't tested it.

Copy link
Contributor

@Berylskid Berylskid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some games with pnach code that includes gsaspectratio=10:7, and all of them worked flawlessly.

@F0bes F0bes merged commit 6c3cf12 into PCSX2:master Sep 25, 2024
12 checks passed
@Yeedman
Copy link

Yeedman commented Sep 25, 2024

Are you adding these to GameDB? Midnight Club - Street Racing (atleast the NTSC release) has the same "quirk".
works fine on it

@crashGG
Copy link
Contributor Author

crashGG commented Sep 25, 2024

Are you adding these to GameDB? Midnight Club - Street Racing (atleast the NTSC release) has the same "quirk". works fine on it

I just checked the game and you are right. It is obvious in the joy settings screen.

4:3 ratio
Midnight Club - Street Racing_SLUS-20063_4b3
native ratio
Midnight Club - Street Racing_SLUS-20063_native

I usually think that only designers from Japanese companies, especially when porting games from traditional arcades, would keep the 10:7 native ratio.It's hard to imagine a company like Rockstar doing this.

@the-burrito-triangle
Copy link

the-burrito-triangle commented Sep 26, 2024

I think many Japanese game developers were confused as to what aspect ratio should be used. For example: FF X draws squares and ovals with 4:3 or rectangles and circles with the new 10:7 option. Clearly, not everyone agreed on the same aspect ratio when developing this game.

Anyways, the new 10:7 aspect ratio seems to work fine for me so far. Thanks for adding it.

4:3
Screenshot from 2024-09-26 03-04-47

10:7
Screenshot from 2024-09-26 03-04-10

@crashGG crashGG deleted the ratio10_7 branch October 3, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants