-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Error popup on insufficient permissions during memcard conversion #11825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the Windows side too.
You have a bunch of lines with spaces where tabs should be.
Could you also mark variables such as canRead
or fileAttributes
as const?
Would you be able to squash the commits into two and prefix the resulting commit? Using git CLI you can interactive rebase all of your commits and then force push the result back to this branch.. |
6f4cfbc
to
fd781a6
Compare
Hey, could you check if everything is ok now? Lemme know if I missed something. |
Hmm, I will check why its failing |
fd781a6
to
37ac41f
Compare
I've already taken care of it for you. I've just asked some people to test the Windows portion and it will be good to merge. |
It still failed. I just tested it locally with the new commit, and everythign should work. |
c70b3f3
to
064678d
Compare
Why is the #ifdef at 0 indentation? 🤔 |
If you want to use an LLM to help you program, that's fine, it's another tool that can sometimes be valuable. Please don't blindly copy and paste from it though. I was suspicious before, but now I'm 90% confident. The pointless commenting, the completely busted formatting (that I just fixed for you). With all respect I don't want to review a machines code.
It's configured that way in our clang-format. |
064678d
to
5592143
Compare
I'll switch to windows and figure this out.. |
1d4beb6
to
1d973a8
Compare
There, tested on Windows and Linux and it works. |
1d973a8
to
44aaa7e
Compare
Description of Changes
Added a permissions check during the conversion of a memory card. It occurred to me that if somehow the permissions change during the setup of the conversion, then it will finish successfully, but wont be copied over to the new directory.
Furthermore, I also made a slight modification to the
build-dependencies.sh
, as I had an error when using curl.More specifically:
curl: (33) HTTP server does not seem to support byte ranges. Cannot resume.
Rationale behind Changes
Its just a bug fix. Helps user understand what went wrong.
Suggested Testing Steps
sudo chmod 000 ./memory_save
)This time you should get an error popup.