GS/HW: Fix/cleanup pabe optimization condition. #11810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
8bab485 to
1b466d1
Compare
lightningterror
changed the title
github-actions
bot
added
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
GS: Metal
labels
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
1b466d1 to
34d4132
Compare
JordanTheToaster
approved these changes
Sep 14, 2024
lightningterror
changed the title
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
34d4132 to
ae0a1ac
Compare
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
ae0a1ac to
afb8ed1
Compare
lightningterror
changed the title
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
afb8ed1 to
cbaab14
Compare
We should check only if As max is 128, also make sure we are checking the original Alpha C value as it could have been modified for an optimization.
lightningterror
force-pushed
the
gs_pabe_opt_fix
branch
from
cbaab14 to
1a8694f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS/HW: Fix/cleanup pabe optimization condition.
We should check only if As max is 128, also make sure we are checking the original Alpha C value as it could have been modified for an optimization.
Rationale behind Changes
Bugfix.
Suggested Testing Steps
Follow up from #11737 test the same games mentioned in that pr.