Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install translations in PACKAGE MODE #11788

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

Nenderus
Copy link
Contributor

@Nenderus Nenderus commented Sep 8, 2024

Description of Changes

Installs localization files when the PACKAGE_MODE option is enabled

Rationale behind Changes

If you use the PACKAGE_MODE option, the localization files still have to be placed in the translations folder relative to the pcsx2-qt binary file, which is unacceptable for packaging in a package for Linux

Suggested Testing Steps

Run with a locale other than en_US and make sure that the interface uses the correct locale

image

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@weirdbeardgame
Copy link
Contributor

Sorry, was working on fixing that bit. Thanks for the PR :)

@F0bes
Copy link
Member

F0bes commented Sep 8, 2024

Changes are good, can you please prefix your commit though. Something like CMake: or Translations: will do.

@Nenderus Nenderus force-pushed the install_translations branch from 14cb56d to dc37f31 Compare September 8, 2024 19:25
@Nenderus
Copy link
Contributor Author

Nenderus commented Sep 8, 2024

Changes are good, can you please prefix your commit though. Something like CMake: or Translations: will do.

Done

@Nenderus Nenderus force-pushed the install_translations branch from dc37f31 to fb6af89 Compare September 9, 2024 06:35
@F0bes F0bes merged commit 4963ea9 into PCSX2:master Sep 10, 2024
12 checks passed
@Nenderus Nenderus deleted the install_translations branch September 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants