-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS: Update lottes crt shader. #11783
Conversation
92021f4
to
076cc57
Compare
@stuken Any update on the brightness suggestions so it can match master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump shader cache in ShaderCacheVersion.h
.
076cc57
to
c764b41
Compare
The old one did not follow the defaults with the mask values set too low. Things are now in line with the reshade and libretro slang/glsl implementations aside from the removal of the brightboost param which can be user configured with shade boost and the mask set to 4 as that's just my personal preference. see https://github.com/Zackin5/Misc-ReShade-Shaders/blob/master/CRT-Lottes.fx#L61C1-L73C9 Bumped the shader cache version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new shader warnings need to be addressed too, these are on dx, others seem fine?
ps_5_0' compiled with warnings:
(158,36-64): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
(168,45-59): warning X3571: pow(f, e) will not work for negative f, use abs(f) or conditionally handle negative values if you expect them
(431,26-42): warning X3578: Output value 'ps_filter_lottes' is not completely initialized
c764b41
to
a69cff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Description of Changes
Updates lottes crt to be in line the latest version.
Rationale behind Changes
The original gs.fx version that was the basis of the old shader is fairly old and missing a couple of features added in later revisions. This just brings thing inline with the more recent past. Shadow mask is more pronounced now and there is a subtle bloom pass.
Old:
New:
Suggested Testing Steps
Tested against dx/opengl/vulkan locally with no issues. Metal is untested.