Big Picture: Remove ability to make per-game controls #11744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
requested changes
Aug 26, 2024
pcsx2/ImGui/FullscreenUI.cpp
Outdated
| { | ||
| ImGuiFullscreen::ChoiceDialogOptions options; | ||
| std::vector<std::string> names; | ||
|
|
There was a problem hiding this comment.
You dropped some tabs here.
This is the second time GitHub's diff tool doesn't show a line of tabs.
Replace with profile selector instead
RedPanda4552
force-pushed
the
per-game-controls-go-away-please
branch
from
cb395f8 to
f477387
Compare
F0bes
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes the option to make literal per-game mappings, and PCSX2's ability to read them. Instead introduces the same input profile selector found in the normal UI to Big Picture.
Rationale behind Changes
This allows the same functionality of having controls customizable on a per-game basis, but in the same clean sandbox of profiles as in the desktop UI. This in turn fixes the issues we've been having with controls being seemingly "stuck", because they are crammed into game properties files when the user never really wanted them to be.
Suggested Testing Steps
Create a new profile, set mappings which purposely don't make sense or are partially incomplete so that it is extra obvious when you have one profile vs another enabled, then test swapping profiles via each UI mode and using said controls. Swap profiles in and out both in desktop and big picture mode, ensuring that both UIs react to when you change profiles both on itself and the other UI.