GS: Match data types in shaders to be the same when doing bitwise operations. #11691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
labels
lightningterror
force-pushed
the
gs_shader_data_types
branch
from
81a1f05 to
d3d21df
Compare
JordanTheToaster
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS: Match data types to be the same in shaders.
Rationale behind Changes
Fixes shader warnings on gl on linux, mesa, or windows using mesa gl drivers.
Also changed dx and vk for consistency.
Suggested Testing Steps
Test GOW on OpenGL, see if the warnings are fixed using mesa drivers on linux/windows.