Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Add fixes for Shadow of the Colossus and Puchi Copter 2 #11609

Closed
wants to merge 1 commit into from
Closed

GameDB: Add fixes for Shadow of the Colossus and Puchi Copter 2 #11609

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2024

Description of Changes

Title.

Rationale behind Changes

Wander was drifting when charging his sword due to rounding issues. Fixes #11528
Puchi Copter 2 was hanging. I created a patch for it (edit: jp's fix in this pr is incorrect. Its fix can be found in the issue listed here >). Fixes #10380

Suggested Testing Steps

Not needed. I finished Shadow of the Colossus with it enabled. And tested Puchi Copter 2 for a while for TLB misses and possible hanging.

@ghost
Copy link
Author

ghost commented Jul 20, 2024

Extremely sorry for the mess. Github is alien to me.

@Mrlinkwii
Copy link
Contributor

Mrlinkwii commented Jul 20, 2024

Was this patch tested ? Can you also not close the issue for puchi copter 2

@ghost
Copy link
Author

ghost commented Jul 20, 2024

Was this patch tested ?

Multiple times. I tested it by applying it through the debugger after the freeze occurs, and through the gameindex. Both instances it was working perfectly fine.

@ghost
Copy link
Author

ghost commented Jul 20, 2024

@Mrlinkwii If you guys are apprehensive about this, I can close this pr and let you do what you want to. It's what I prefer cause this is a mess I'm new to.

@ghost ghost closed this Jul 20, 2024
@ghost
Copy link
Author

ghost commented Jul 20, 2024

Some of them weren't applying in PCSX2. Perhaps I wrote them incorrectly? Regardless, I'll close it and have someone else do prs till I get this right one day.

Edit: also, I seemed to have incorrectly added eu's patch to jp in this pr. Jp's fix can be found in the issue listed.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant