Qt UI: Add text for new upscaling options #11500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title includes exclamation mark. "Make War, Not Love!" is a tagline, not part of the title. Removed.
Well there is still a silent majority that doesn't interact (much) with Discord or GitHub and if it works then they have no reason to. So I would be careful taking observations in decisions. Though if you gonna update, might as well add the labels for the higher upscaling ones: 12x Native (~4320p/8K) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rationale behind Changes
Stenzek recently changed upscaling options to up to 12x by default; this adds text for those new options like we do for the old ones. Furthermore, in Advanced Settings, you can now go up to a resolution limited by your hardware specifications; this goes up to 25x for seemingly most people.
Regarding the removal of 2.25x and 2.75x, whereas 2.5x or 900p seems very reasonable, the 2.25x and 2.75x multipliers seem to just take up space, and I have never heard of anybody using them.
Suggested Testing Steps
Enable Advanced Settings and look up to 25x. Also try without Advanced Settings enabled to make sure I didn't break anything for the default user experience.