GS/HW: Allow use of trilinear with shader sampling #11448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TW/TH won't match when mipmap minimization eliminates the base level. Use the TEX0 register from the context instead.
github-actions
bot
added
GS
GS: Hardware
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
GS: Metal
labels
Mrlinkwii
approved these changes
Jun 23, 2024
JordanTheToaster
approved these changes
Jun 23, 2024
kamfretoz
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Apparently this was completely missing, whoops.
Also enables clamp elimination in mipmapped situations, which is important due to us having mipmapping on by default now. TW/TH won't match when mipmap minimization eliminates the base level, so use the TEX0 register from the context instead.
Rationale behind Changes
Fixes #11441.
Couple of other noteworthy mentions:
Suggested Testing Steps
Check linked dump on all renderers.
Smoke test, runner says we good.