GS/Vulkan: Release swap chain images on acquire fail #11445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrlinkwii
approved these changes
Jun 23, 2024
kamfretoz
approved these changes
Jun 23, 2024
|
Would need to test this a lot but for what I had test it doesn't seem to cause arch linux to have a mental collapse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When image acquire returns suboptimal, apparently we should release the swap chain image we just acquired, because apparently that doesn't happen implicitly on creation of a new swap chain? (if you're transferring, not destroying/creating).
Rationale behind Changes
Related to #11280.
Suggested Testing Steps
See if the leak/driver crash occurs.