GS/HW: Keep real rect before draw to avoid bad valid rect update #11419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Keeps the correct draw rect for the final clean up of draws.
Rationale behind Changes
the draw rect was getting changed to 1024x1024 when a channel shuffle happened, causing the validrect update check to mistakingly pass, this meant we had targets saying they were huge, taking up most of the memory and misfiring, most notably in Valkyrie Profile 2.
Suggested Testing Steps
Test Valkyrie Profile 2 (already done), dump run also good, probably just gonna merge when it builds.