GS/HW: Allow offset channel shuffles on sources. #11413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Allows offsetting in to render targets on offset channel shuffles.
Rationale behind Changes
A bunch of games do channel shuffles in such a way we can't override it and HLE it, so this allows that to work, but also accounts for both the draw and the read being offset by a number of blocks (block layout matches, so this is allowed). This means as a result a lot of uploads etc are reduced.
As a result, we can now upscaled Monster Lab, just be careful as it gets heavy, plus this gets rid of a readback, so it should increase performance on some machines.
Suggested Testing Steps
Check the following games.
Hitman - Blood Money (just make sure it's no worse, it should be fine, but won't be fixed)
Draw Calls: -4 [492=>488]
Render Passes: -5 [396=>391]
Copies: -1 [31=>30]
Uploads: -1 [47=>46]
Monster_Lab
Draw Calls: +1 [548=>549]
Render Passes: +1 [17=>18]
Copies: +1 [3=>4]
Uploads: -132 [151=>19]
Readbacks: -1 [2=>1]
Tomb_Raider_-_Legend
Draw Calls: -74 [273=>199]
Render Passes: -62 [102=>40]
Uploads: -14 [40=>26]
8x Upscaling Monster Lab: (Keep in mind it will be very slow in this resolution)
Master:
PR:
