GS: Correct depth trace for sprites + optimize HW depth selection #11391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
reviewed
Jun 14, 2024
refractionpcsx2
force-pushed
the
gs_correctdepth
branch
from
01855e2 to
9807abb
Compare
refractionpcsx2
changed the title
Mrlinkwii
approved these changes
Jun 14, 2024
JordanTheToaster
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Corrects depth trace correction for sprites and tries to optimise out making new depth targets when they aren't required.
Rationale behind Changes
The correct depth trace was checking every vertex for Z values, where only every second one is valid on sprites, meaning the "equal" test was failing. This is now fixed.
Also added some code to later optimise the "all tests pass" when it's selecting the depth targets.
Suggested Testing Steps
Nothing really fixed.
Smoke test I guess