GS/HW: Don't kill old targets unless completely dirty or targets overlap #11385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes Shadow Hearts, doesn't break FFX pause menu or battle transition. |
|
Thanks for testing :) |
kamfretoz
approved these changes
Jun 15, 2024
JordanTheToaster
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Stops killing targets that are just a little bit dirty.
Rationale behind Changes
No real need to destroy the whole target because it's slightly dirty, doesn't make a lot of sense if there isn't another target over it.
Suggested Testing Steps
Try Shadow hearts pause menu (already checked with GS Dump)
Fixes Shadow Hearts pause screens.
Before:
PR:
(the bit at the bottom is a TODO, pretend that's not there)
Edit: Decided to fix this other bug, so now it looks fine.