Qt: Hide texture directory option per-game #11366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of hiding it, it would be nice to actually implement the feature since it can be useful. |
|
That's maybe something for the future. |
stenzek
reviewed
Jun 10, 2024
|
Pull requests welcome if you want to implement it :) None of us are interested in doing so, and IMO it's unnecessary, because there's already game-specific texture directories, and if you want to put it on a different volume, you can symlink it. |
kamfretoz
force-pushed
the
texrep-cleanup
branch
from
6b904a6 to
d568ab3
Compare
stenzek
reviewed
Jun 12, 2024
kamfretoz
force-pushed
the
texrep-cleanup
branch
from
d568ab3 to
a1d482b
Compare
|
Also attempted to cleanup some of the internal labels too. |
Mrlinkwii
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR hides the option to change the texture/video dumping directory per-game since on Master, it is locked out and the Open Directory button is broken anyway.
Master:
PR:
Rationale behind Changes
Cleanliness 100
Suggested Testing Steps
See if the option is properly hidden per-game and that i didn't break anything else.