Qt: Add very-early VC++ runtime version check #11361
Conversation
| HeapFree(heap, 0, version_block); | ||
| HeapFree(heap, 0, filename); | ||
|
|
||
| if (v0 >= MIN_VERSION_V0 && v1 >= MIN_VERSION_V1 && v2 >= MIN_VERSION_V2) |
There was a problem hiding this comment.
This can cause some issues in the future. If V0 is strictly greater than MIN_VERSION_V0, there is no reason to check for V1 and V2 (and same for V1 with V2).
For example msvc version 14.39.0.0 would fail this check and display the warning prompt, which I don't think is intended.
There was a problem hiding this comment.
I think this is a common trip up when doing version number checks, you need to do
v0 > Min_version0 || (v0 == min_version0 && (v1 > min_version1 || (v1 == min_version1 && v2 >= min_version2)))
I think that covers all bases.. lol
There was a problem hiding this comment.
Yes, that should work. Another way would be to convert v0, v1 and v2 to a single 64-bit integer and compare it to the one made from MIN_VERSION_{V0,V1,V2} I guess (it may look nicer)
There was a problem hiding this comment.
Whoops, yeah, originally I had it the other way around, but stuffed up the inversion.
Description of Changes
Backport of stenzek/duckstation@a2e6a48
Rationale behind Changes
MS decided to effectively break the ABI with the Visual C++ runtime, resulting in crashes if a user tries to run a newer PCSX2 on an out-of-date runtime. Throw an error up, and prompt them to update instead of crashing.
Suggested Testing Steps
Try the PR build on an old install.