UI: Rename Wild Arms hack #11356
Merged
UI: Rename Wild Arms hack #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Hardware
Translations
GameDB
Documentation
GUI/Qt
labels
JordanTheToaster
force-pushed
the
hacky-whacky
branch
from
f0e16ad to
8564b93
Compare
JordanTheToaster
force-pushed
the
hacky-whacky
branch
from
8564b93 to
2718baa
Compare
|
The tooltip should be more descriptive of what it does. And if changed, it should also mention something like |
JordanTheToaster
force-pushed
the
hacky-whacky
branch
3 times, most recently
from
2e92cee to
9d083ab
Compare
JordanTheToaster
force-pushed
the
hacky-whacky
branch
from
9d083ab to
07390b0
Compare
Mrlinkwii
approved these changes
Jun 10, 2024
JordanTheToaster
force-pushed
the
hacky-whacky
branch
from
07390b0 to
bc8a510
Compare
kamfretoz
approved these changes
Jun 10, 2024
|
Missed this during the testing, the text for the checkbox doesn't appear and the GameDB entry for it aren't getting loaded. |
JordanTheToaster
force-pushed
the
hacky-whacky
branch
3 times, most recently
from
4570279 to
087dd0b
Compare
All should be fixed now. |
JordanTheToaster
force-pushed
the
hacky-whacky
branch
2 times, most recently
from
c33861d to
955e9fd
Compare
Mrlinkwii
approved these changes
Jun 13, 2024
JordanTheToaster
force-pushed
the
hacky-whacky
branch
from
955e9fd to
06cb516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Renames the Wild Arms hack to something closer to what it actually does internally.
Rationale behind Changes
More logical naming and less game related hacks good.
Suggested Testing Steps
Make sure CI is happy the hack still functions and it loads properly from the DB in games that have it as a gamefix.