GS/HW: Extend blend second pass to more blend formulas v2. #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GS
GS: Hardware
GS: Direct3D 11
GS: OpenGL
GS: Vulkan
GS: Direct3D 12
labels
stenzek
reviewed
Jun 8, 2024
Cd*(1 + Alpha). Alpha = As, Ad or Af. For As or Af case when alpha > 128. For Ad case when there is no RTA correction.
Better readability.
lightningterror
force-pushed
the
gs_extend_blend_pass2_v2
branch
from
db356e4 to
097473a
Compare
|
Midnight Club dub remix and underground don't seem to have any regressions neither new issues with this PR with all renders Master: GSDumps: Underground: Master: Master: Master: GSDumps: |
JordanTheToaster
approved these changes
Jun 14, 2024
AmyRoxwell
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Cd*(1 + Alpha).
Alpha = As, Ad or Af.
For As or Af case when alpha > 128.
For Ad case when there is no RTA correction.
Rationale behind Changes
Accuracy.
Suggested Testing Steps
Test the listed dumps:
There shouldn't be any diffs or minimal since the alpha isn't higher than 128 in these games.
Found a few where it is higher than 128 but with overlap so won't help in those cases.