Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Corrects type for stub implementation of
AutoUpdaterDialog::processUpdate()
Define
MAP_FIXED_NOREPLACE
asMAP_FIXED | MAP_EXCL
, which should serve the same purposeRationale behind Changes
Some socket code is common between Mac and FreeBSD, but not Linux.
Setting up a FreeBSD VM for testing is cheaper then getting a Mac (I mean, it's in the name)
Suggested Testing Steps
It's still a bit of effort compile for FreeBSD, In addition to this PR you would need to deal with the following issues;
Qt with Multitouch fails to compile, due to code intended to support FreeBSD you can do one of the following;
Disable Multitouch with
-no-mtdev
or apply the same Qt base/wayland patches FreeBSD's port does.cpuinfo doesn't support FreeBSDLocally apply either pytorch/cpuinfo#230 or pytorch/cpuinfo#172, I think the port uses the former.
Incorrect shaderc headers being used when system installed shaderc is present.
/usr/local/include
is not treated as an implicit include (unlike Ubuntu)This leaves us at the mercy of cmake's ordering, which ends up being incorrect.
Somehow none of the system provided dependencies we use mark this directory as a
SYSTEM
, so cmake see fit to have this as the very first include directory.deps/include
gets marked asSYSTEM
, so appears a fair bit later in the search order.Providing an environment variable
CXXFLAGS="-isystem /usr/local/include"
manages to get includes in the correct order.Or alternatively apply #11292 which also enforces correct include order.
I dunno if that last issue is an problem with my configuration, or something FreeBSD has messed up.