HeapArray: Avoid writing out of bounds in internal_resize #11139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
I noticed that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The non-MSVC implementation of
DynamicHeapArray<T>::internal_resizecontains a buffer overrun when the new size is smaller than the previous size, as it just performs amemcpy(data, prev, prev_size)without checking the size ofdata. This PR fixes the problem by usingmin(size, prev_size)instead ofprev_size.Rationale behind Changes
This issue caused a crash when changing from 128MB RAM back to the default 32MB RAM in #11111 on Linux.